Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.1.0 #1067

Merged
merged 4 commits into from
Jul 21, 2024
Merged

v1.1.0 #1067

merged 4 commits into from
Jul 21, 2024

Conversation

donavanbecker
Copy link
Contributor

v1.1.0 (2024-07-21)

Changes

  • Set Ciao as the default Advertiser

Other Changes

  • Update docs
  • Updated dependencies

donavanbecker and others added 4 commits July 20, 2024 23:38
@donavanbecker
Set ciao as default advertiser
178a066
@donavanbecker
Set ciao as default advertiser (#1066)
769298f
@donavanbecker
v1.1.0
3652113 
## v1.0.0 (2024-07-21)

### Changes

- Set `Ciao` as the default Advertiser

### Other Changes

- Updated dependencies
@donavanbecker
update docs
e5c0bb1
bwp91
bwp91 approved these changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@bwp91 bwp91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a very visible note to https://github.com/homebridge/homebridge/wiki/Updating-To-Homebridge-v2 about this change.

That the default advertiser has changed - and if a user wants to continue using bonjour then they should specifically set this BEFORE updating to HB2.0

@donavanbecker
Copy link
Contributor Author

We should add a very visible note to https://github.com/homebridge/homebridge/wiki/Updating-To-Homebridge-v2 about this change.

That the default advertiser has changed - and if a user wants to continue using bonjour then they should specifically set this BEFORE updating to HB2.0

That is a good idea, I have added a note. Let me know if you think we should add more.

@donavanbecker donavanbecker requested a review from bwp91 July 21, 2024 20:41
@donavanbecker donavanbecker enabled auto-merge July 21, 2024 20:41
@donavanbecker donavanbecker disabled auto-merge July 21, 2024 20:51
@donavanbecker donavanbecker enabled auto-merge July 21, 2024 21:23
@donavanbecker donavanbecker marked this pull request as draft July 21, 2024 22:32
auto-merge was automatically disabled July 21, 2024 22:32

Pull request was converted to draft

@donavanbecker donavanbecker marked this pull request as ready for review July 21, 2024 22:32
@donavanbecker donavanbecker merged commit 8804db5 into latest Jul 21, 2024
33 checks passed
@donavanbecker donavanbecker deleted the beta-1.1.0 branch July 21, 2024 22:36
@n0rt0nthec4t
Copy link

Seems this release locked the node engine versions to either 18.x.x or 20.x.x. Wondering what the reason for that? Latest docker node container is using 22.5.1 which prevents this from running. Should the package.json engine version be changed to >= 18.0.0?

@donavanbecker
Copy link
Contributor Author

Seems this release locked the node engine versions to either 18.x.x or 20.x.x. Wondering what the reason for that? Latest docker node container is using 22.5.1 which prevents this from running. Should the package.json engine version be changed to >= 18.0.0?

^18 || ^20 was set with v1.0.0. We wouldn't want to set it with >=18 because we don't support odd node releases and node 22 isn't LTS yet so we haven't added it to the engine yet. Once 22 is LTS, then we will added it as ^18 || ^20 || ^22 or ^20 || ^22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NorthernMan54 NorthernMan54 Awaiting requested review from NorthernMan54

@hjdhjd hjdhjd Awaiting requested review from hjdhjd

@bwp91 bwp91 Awaiting requested review from bwp91

Assignees
No one assigned
Labels
latest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donavanbecker @n0rt0nthec4t @bwp91