forked from microsoft/node-pty
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Official NPM package link on GitHub #31
Labels
bug
Something isn't working
Comments
stefreak
added a commit
to garden-io/garden
that referenced
this issue
Nov 7, 2023
Apparently the NPM package name changed; I opened an issue upstream to clarify because the github repo still links to the old NPM repo. homebridge/node-pty-prebuilt-multiarch#31
stefreak
added a commit
to garden-io/garden
that referenced
this issue
Nov 7, 2023
Apparently the NPM package name changed; I opened an issue upstream to clarify because the github repo still links to the old NPM repo. homebridge/node-pty-prebuilt-multiarch#31
@stefreak We moved this into the Homebridge domain earlier this year, and the homebridge collaborator team has taken over ongoing support for the package. Hence the recent updates etc. The original author is still around, he is just occupied with other things these days. Tks for pointing out the incorrect link, we have corrected it. |
Awesome, thanks a lot! |
github-merge-queue bot
pushed a commit
to garden-io/garden
that referenced
this issue
Nov 9, 2023
* chore: bump to node 21.1.0 * chore: fix linter complaint * chore: use new npm modules cache * fix: ts-node/esm module loader * fix: try to see if an explicit import hook register works to fix ts-node esm performance * chore: fix shebang lines * fix: install nodejs using fnm (if needed) * fix: checksum * fix: use getAbi correctly * chore: test nodejs version as separate step * fix: make nodejs install work with machine executor * chore: update node-pty-prebuilt-multiarch to 0.11.10 Apparently the NPM package name changed; I opened an issue upstream to clarify because the github repo still links to the old NPM repo. homebridge/node-pty-prebuilt-multiarch#31 * chore: bump typescript types and eslint packages * chore: make no-explicit-any a warning only * fix: consistent versions for node-pty-multiarch * fix: alpine docker sha hash * fix: clean up unwanted log messages in the release binary * fix: musl checksum * fix: avoid issues due to cache poisoning * fix: wait until write stream is finished Co-authored-by: Tim Beyer <TimBeyer@users.noreply.github.com> * fix: use pipeline to await until write stream really finished * fix: properly implement streaming * chore: update circleci machine image * fix: add env var UV_USE_IO_URING=0 to avoid kernel bug Libuv 1.45.0 is affected by a kernel bug on certain kernels (Ubuntu 22) This leads to errors where Garden tool downloading errors with ETXTBSY Apparently file descriptor accounting is broken when using USE_IO_URING on older kernels See also libuv/libuv#4141 * fix: tested error message became more detailed --------- Co-authored-by: Steffen Neubauer <steffen@garden.io> Co-authored-by: Tim Beyer <TimBeyer@users.noreply.github.com> Co-authored-by: Garden CI <admin@garden.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Analysis
On github the NPM package link points to node-pty-prebuilt-multiarch which was last updated 2 years ago
The github action seems to publish to @homebridge/node-pty-prebuilt-multiarch
Which one is the official package? Should the link be updated? Have the credentials to the other account been lost? (If yes, that should be announced as a security advisory / CVE so that people switch to the new package)
Expected Behavior
I expect the link on github to point to the official package that gets updated regularly.
Steps To Reproduce
Click on the website link on github:
Logs
Configuration
N/A
Environment
N/A
Process Supervisor
not applicable
Additional Context
No response
The text was updated successfully, but these errors were encountered: