Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update munki_makecatalogs.py #72

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

kbrewersq
Copy link
Contributor

It looks like you updated this to stop looking defining python, but missed the main where it checks for the existence of the python variable.

error i see on v1.14.1

Run Munki Makecatalogs...................................................Failed
- hook id: munki-makecatalogs
- exit code: 1

Traceback (most recent call last):
  File "/Users/kbrewer/.cache/pre-commit/repoehdjx6fz/py_env-python3.12/bin/munki-makecatalogs", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/kbrewer/.cache/pre-commit/repoehdjx6fz/py_env-python3.12/lib/python3.12/site-packages/pre_commit_hooks/munki_makecatalogs.py", line 38, in main
    elif not os.path.isfile(python):
                            ^^^^^^
NameError: name 'python' is not defined

@homebysix
Copy link
Owner

Good catch, thanks!

@homebysix homebysix merged commit 3fea144 into homebysix:main Jan 1, 2024
@kbrewersq kbrewersq deleted the kbrewer-fix-python branch January 3, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants