Corections to meta extension #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct oder to or and numerals in example to keys .
EP-u-NW
approved these changes
Jul 17, 2019
EP-u-NW
suggested changes
Jul 17, 2019
There was a problem hiding this comment.
You are right, there should be no numbers.
But in your correction, you assigned the topic id "alexa" to the "HomeKit" key. While this is technically allowed according to the extension specification, I actually intended to assign the "Alexa" key value to the "alexa" topic, and the "HomeKit" key value to the "homekit" topic.
Edit: So what i mean is: you changed the numeral "0" to "alexa", while it would me more appropriate to change "0" to "homekit" and "1" to "alexa".
|
Sory, my mistake |
|
Can you make an other commit to fix this :) ? |
|
Corrected. |
EP-u-NW
approved these changes
Jul 17, 2019
davidgraeff
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct oder to or and numerals in example to keys .