-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: track exceptions in :solid_queue #526
Conversation
And any other ActiveJob adapters that come along :) Fixes #518
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
In the future we may be able to use the new Rails error reporting API to capture exceptions (we already integrate with it, but I don't know how it works with ActiveJob). |
Do I understand right that I can update the gem and remove my extra |
Yup, that should work, though I didn't keep the |
This change has caused the number of exceptions tracked from rubygems.org to explode. We have jobs with |
Because that version introduced unwanted exception reporting, exceeding our quota Issue reported upstream in honeybadger-io/honeybadger-ruby#526 (comment)
Have you tried 5.8.0, which includes 2237541 ? |
yes, we were on 5.8.0 rubygems/rubygems.org#4598 |
And any other ActiveJob adapters that come along :)
Fixes #518