Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: track exceptions in :solid_queue #526

Merged
merged 4 commits into from
Mar 5, 2024

Conversation

stympy
Copy link
Member

@stympy stympy commented Mar 5, 2024

And any other ActiveJob adapters that come along :)

Fixes #518

And any other ActiveJob adapters that come along :)

Fixes #518
@stympy stympy requested a review from joshuap March 5, 2024 14:21
Copy link
Member

@joshuap joshuap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@joshuap
Copy link
Member

joshuap commented Mar 5, 2024

In the future we may be able to use the new Rails error reporting API to capture exceptions (we already integrate with it, but I don't know how it works with ActiveJob).

@stympy stympy merged commit 4e2d428 into master Mar 5, 2024
59 checks passed
@searls
Copy link

searls commented Mar 5, 2024

Do I understand right that I can update the gem and remove my extra rescue_from(Exception) in my jobs?

@stympy
Copy link
Member Author

stympy commented Mar 5, 2024

Do I understand right that I can update the gem and remove my extra rescue_from(Exception) in my jobs?

Yup, that should work, though I didn't keep the controller value or the logging that you had.

@segiddins
Copy link

This change has caused the number of exceptions tracked from rubygems.org to explode. We have jobs with rescue_from handlers that handle specific exceptions, and after upgrading to 5.6.0 those are all now being reported to honey badger, even though we don't want them to be

segiddins added a commit to rubygems/rubygems.org that referenced this pull request Apr 11, 2024
Because that version introduced unwanted exception reporting, exceeding our quota

Issue reported upstream in honeybadger-io/honeybadger-ruby#526 (comment)
@stympy
Copy link
Member Author

stympy commented Apr 11, 2024

This change has caused the number of exceptions tracked from rubygems.org to explode. We have jobs with rescue_from handlers that handle specific exceptions, and after upgrading to 5.6.0 those are all now being reported to honey badger, even though we don't want them to be

Have you tried 5.8.0, which includes 2237541 ?

@segiddins
Copy link

yes, we were on 5.8.0 rubygems/rubygems.org#4598

@stympy stympy deleted the feat-track-exceptions-in-solid-queue branch July 11, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exceptions raised in jobs from Solid Queue are not automatically reported
4 participants