fix: access GoodJob config via Rails.application.config #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting GoodJob's error handler with config.good_job.on_thread_error= in an initializer doesn't change GoodJob.on_thread_error by the time our plugin gets loaded.
joshuap
reviewed
May 29, 2024
There was a problem hiding this comment.
We initialize our plugins after Rails' initializers run, but not necessarily after other gems' callbacks are executed. I think what's probably happening is GoodJob is configuring their stuff after our after_initialize callback runs:
This workaround seems OK to me for Rails, but do people ever configure GoodJob directly?
I decided to ignore that possibility since this change is just about ActiveJob being used inside Rails. :) |
🧠 |
joshuap
approved these changes
May 29, 2024
roelbondoc
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting GoodJob's error handler with
config.good_job.on_thread_error=in an initializer doesn't changeGoodJob.on_thread_errorby the time our plugin gets loaded.