Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --insights flag to install command #564

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

excid3
Copy link
Contributor

@excid3 excid3 commented Jun 14, 2024

This makes it easy to enable (or disable) Honeybadger Insights when installing in an application.

bundle exec honeybadger install apikey --insights

cc @joshuap

This makes it easy to enable (or disable) Honeybadger Insights when
installing in an application.

```bash
bundle exec honeybadger install apikey --insights
```
Copy link
Member

@joshuap joshuap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks @excid3! I made a minor change to the config key name.

@stympy @roelbondoc do you like the naming of this flag? (--insights and --no-insights?)

lib/honeybadger/cli/install.rb Outdated Show resolved Hide resolved
spec/features/install_spec.rb Outdated Show resolved Hide resolved
spec/features/install_spec.rb Outdated Show resolved Hide resolved
@stympy
Copy link
Member

stympy commented Jun 14, 2024

@stympy @roelbondoc do you like the naming of this flag? (--insights and --no-insights?)

WFM. Thanks, @excid3!

@roelbondoc
Copy link
Member

do you like the naming of this flag? (--insights and --no-insights?)

This sounds good to me!

@joshuap joshuap changed the title Adds --insights to install command feat: add --insights flag to install command Jun 14, 2024
@joshuap joshuap merged commit 02a41c6 into honeybadger-io:master Jun 14, 2024
41 checks passed
@excid3 excid3 deleted the insights-flag branch June 17, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants