Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't raise errors in instrumentation metrics #627

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

roelbondoc
Copy link
Member

Raising an error just because a value isn't specified is a little too aggressive. Instead, we can still register the metric and just log the issue. This should prevent unwanted exceptions from bubbling up into the application. We should also not send any metrics if no samples have been collected.

Before submitting a pull request, please make sure the following is done:

  1. If you've fixed a bug or added code that should be tested, add tests!
  2. Run rake spec in the repository root.
  3. Use a pull request title that conforms to conventional commits.

Raising an error just because a value isn't specified is a little too
aggressive. Instead, we can still register the metric and just log the
issue. This should prevent unwanted exceptions from bubbling up into the
application. We should also not send any metrics if no samples have been
collected.
@roelbondoc roelbondoc requested a review from a team November 1, 2024 16:31
@roelbondoc roelbondoc merged commit 1231dae into master Nov 2, 2024
59 checks passed
@roelbondoc roelbondoc deleted the fix-dont-raise-errors-in-instrumentation branch November 2, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants