feat: set context during rails error report #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will always set the context from Rails when an error is reported even if it is not handled. This will allow applications to use `Rails.error.set_context` instead of `Honeybadger.context` and still see that context in errors in the UI. It would have been nice if Rails provided an event for when `set_context` is called so that we can hook into that, but this should be ok for now.
stympy
approved these changes
Nov 26, 2024
roelbondoc
deleted the
648-honeybadger-rack-middleware-ignores-rails-error-context-when-creating-notice-for-unhandled-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will always set the context from Rails when an error is reported even if it is not handled. This will allow applications to use
Rails.error.set_contextinstead ofHoneybadger.contextand still see that context in errors in the UI.It would have been nice if Rails provided an event for when
set_contextis called so that we can hook into that, but this should be ok for now.Closes: #648
Before submitting a pull request, please make sure the following is done:
rake specin the repository root.