feat: use after_change for context changes #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an application uses `Rails.error.set_context` to set context, the gem does not see this data until an error is reported. This change uses the `ActiveSupport::ExecutionContext.after_change` callback so that we can always keep track of context changes. This ensures we can report errors with the proper context outside of Rails error report handling.
stympy
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an application uses
Rails.error.set_contextto set context, the gem does not see this data until an error is reported. This change uses theActiveSupport::ExecutionContext.after_changecallback so that we can always keep track of context changes. This ensures we can report errors with the proper context outside of Rails error report handling.Closes: #648
Specifically, this will also fix the issue with the way we report errors for ActiveJob.
Before submitting a pull request, please make sure the following is done:
rake specin the repository root.