Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flask-sqlalchemy] db.query_args appears as the param names, not param values #62

Closed
benregn opened this issue May 2, 2019 · 2 comments · Fixed by #63
Closed

[flask-sqlalchemy] db.query_args appears as the param names, not param values #62

benregn opened this issue May 2, 2019 · 2 comments · Fixed by #63

Comments

@benregn
Copy link

benregn commented May 2, 2019

The problem seems to be that the parameters argument to the before_cursor_execute listener is almost always (maybe always) a dict in my project. Beeline always treats it as if it's a list: https://github.com/honeycombio/beeline-python/blob/634a567/beeline/middleware/flask/__init__.py#L115.

Quote from the docs about the parameters argument:

Dictionary, tuple, or list of parameters being passed to the execute() or executemany() method of the DBAPI cursor. In some cases may be None.

@tredman
Copy link
Contributor

tredman commented May 10, 2019

Hey! Sorry for the delay, but I haven't forgotten about this. I'll take a look shortly and get back to you.

@tredman
Copy link
Contributor

tredman commented May 13, 2019

This should be fixed in 2.5.1 of the beeline, please update when you get a chance and let us know if you still see any issues.

@tredman tredman reopened this May 13, 2019
@tredman tredman closed this as completed May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants