Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add instrumentation to generator functions #106

Merged
merged 1 commit into from
Mar 23, 2020
Merged

add instrumentation to generator functions #106

merged 1 commit into from
Mar 23, 2020

Conversation

reuben-sutton
Copy link
Contributor

@reuben-sutton reuben-sutton commented Mar 20, 2020 •
edited
Loading

At present, instrumenting a generator function with @beeline.traced which calls other generator functions results in the following odd behaviour:

  • The generator function's timing is the time taken to return the generator, not the time the generator takes
  • The generator’s span is not the parent of any child spans

@tredman tredman self-requested a review March 23, 2020 19:17
@tredman tredman merged commit ed337a9 into honeycombio:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tredman tredman Awaiting requested review from tredman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reuben-sutton @tredman