Allow overriding context for Django Middleware. #73
Conversation
|
Unsure if the change I made is desirable for the general project, but this way I think it is easier to override the "what gets sent" from the "when does it get sent". |
By subclassing `django.HoneyMiddlewareBase`, it is now possible to change the context that gets sent to Honeycomb. See honeycombio#72.
sjoerdjob
force-pushed
the
django-allow-overriding-context
branch
from
880d934 to
412c082
Compare
eanakashima
requested review from
tredman and
asdvalenzuela
and removed request for
tredman
|
This LGTM, thanks for the PR! As it's still marked draft I won't merge it yet in case you had some other changes you were looking to add. Since we don't have automated testing of the django middleware here (yet), when I merge, I'll test it against a local environment before cutting a new release. |
|
I only marked it as draft because I was wondering whether you would like to apply the same change to all the other middleware as well, seeing as I would think it would be generally desirable. I'll mark it as "ready for review" so that when you want to merge it's good to go. |
|
Ok, after thinking about it more, I do have one last change I'd like to make: I'd like to add |
ah, makes sense! Yeah I think it'd be worthwhile. Did you have interest in adding that to this PR? If not I can spend a little time adding it before cutting the next release. |
|
I myself do not currently have the availability to do that myself in the upcoming week. If you could do that it would be great. |
|
I'll reply back here when the new release is out. Should have this ready by tomorrow. |
By subclassing
django.HoneyMiddlewareBase, it is now possible tochange the context that gets sent to Honeycomb.
See #72.