[middleware] enable subclassing of other middleware implementations, remove POST in django #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…remove POST in django A mixed bag here: - extend the capability of new `get_context_*` functions in Flask, Bottle, and Werkzeug middlewares - Drop `request.POST.dict()` from default instrumentation in django by default - Adds initial test structure for middleware. At best, this tests that the middleware code executes and doesn't crash due to trivial runtime errors, but there's a long way to go here.
tredman
force-pushed
the
tredman.post-context
branch
from
9cd0660 to
2e74a15
Compare
asdvalenzuela
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mixed bag here:
get_context_*functions in Flask, Bottle, and Werkzeug middlewaresrequest.POST.dict()from default instrumentation in django by default