[middleware] Don't try to access self.state.span in handle_error of Flask DB middleware if there is no current_app #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
before_cursor_execute
andafter_cursor_execute
exit earlyif there is no
current_app
, buthandle_error
tries to finishthe span even if there is no
current_app
. This caused anAttributeError
when I was using beeline-python in the context of amulti-threaded application, since when we used
HoneyDBMiddleware
offof the thread it had been initialized on,
self.state.span
was neverset. We could probably also fix this by using
getattr
onself.state
before accessing
span
, but this seems more consistent with how theother methods operate.