Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Refinery chart #27

Merged
merged 12 commits into from
Mar 30, 2021
Merged

Add Refinery chart #27

merged 12 commits into from
Mar 30, 2021

Conversation

puckpuck
Copy link
Collaborator

Initial release of chart for Refinery.

This Helm chart will depend on this PR getting merged for refinery itself. Hold merging until then.

@puckpuck puckpuck requested review from shelbyspees and a team March 10, 2021 02:01
@puckpuck puckpuck requested a review from McSick March 26, 2021 02:37
@shelbyspees shelbyspees removed their request for review March 26, 2021 21:27
Copy link
Contributor

@vreynolds vreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with a node deployment in k8s going through the helm refinery: seeing events 👍

Something that was not obvious to me: how to discover the refinery service inside the cluster. Maybe worth mentioning in the README? I am pretty novice k8s user, though, so if it's obvious to a seasoned user, no need.

One thing I couldn't get to work is logs: using the default logrus config, I didn't see any logs with kubectl logs, using the honeycomb logger didn't create the logs dataset. Not sure what the issue is, could be my local setup. The only thing I changed in the values file was pointing at the dogfood API.

@@ -0,0 +1,2 @@
Honeycomb refinery is setup and configured to refine events that are sent through it. You should see data flowing
within a few minutes at https://ui.honeycomb.io
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not worth a lot of effort, but if possible: the API is configurable, so this note can be misleading

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the UI link, not the API link.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, so in my case I would be looking at https://ui-dogfood.honeycomb.io. But no one outside Honeycomb would go to another UI, so now that I think about it, it seems OK hard-coded.

@puckpuck puckpuck merged commit 5f661bb into main Mar 30, 2021
@puckpuck puckpuck deleted the refinery branch March 30, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants