Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honeycomb.OpenTelemetry.CommonInstrumentations uses incorrect packages #364

Closed
Al4ric opened this issue Feb 13, 2024 · 1 comment · Fixed by #365
Closed

Honeycomb.OpenTelemetry.CommonInstrumentations uses incorrect packages #364

Al4ric opened this issue Feb 13, 2024 · 1 comment · Fixed by #365
Labels
status: oncall Flagged for awareness from Honeycomb Telemetry Oncall type: bug Something isn't working

Comments

@Al4ric
Copy link

Al4ric commented Feb 13, 2024

Link to my full Program.cs:
https://github.com/Al4ric/ThingsFinder/blob/9412d18597b8aed00374843a1c745bab3d95f6ea/ThingsFinder/Program.cs
Branch: opentelemetry_init

Versions
0.27.1-beta

  • .NET runtime & version (eg .NET Core, .NET Framework): .Net 8.0.200-preview.23624.5
  • Honeycomb OpenTelemetry Distribution: everything in latest versions as of today

Steps to reproduce

Having this setup in Program.cs:

builder.Services.AddOpenTelemetry()
.ConfigureResource(resource => resource.AddService(serviceName))
.WithTracing(tracing => tracing
.AddHoneycomb(honeycombOptions)
.AddCommonInstrumentations()

It builds fine, but when trying to run it causes runtime error:
System.TypeLoadException
Could not load type 'OpenTelemetry.Trace.TracerProviderBuilderExtensions' from assembly 'OpenTelemetry.Instrumentation.Http, Version=1.0.0.0, Culture=neutral, PublicKeyToken=7bd6737fe5b67e3c'.

Additional context
When method AddCommonInstrumentations() is removed - application works fine. Weird thing is that there is no version 1.0.0 of OpenTelemetry.Instrumentation.Http. It was just "RC" versions and went from 1.0.0.rc-9.14 straight to 1.5.0-beta.1
@Al4ric Al4ric added the type: bug Something isn't working label Feb 13, 2024
@MikeGoldsmith
Copy link
Contributor

Interesting - thanks for raising. We'll take a look.

@MikeGoldsmith MikeGoldsmith added the status: oncall Flagged for awareness from Honeycomb Telemetry Oncall label Feb 14, 2024
@MikeGoldsmith MikeGoldsmith mentioned this issue Feb 26, 2024
Merged
MikeGoldsmith added a commit that referenced this issue Feb 27, 2024
@MikeGoldsmith
maint: Bump OpenTelemetry dependencies (#365)
16b354d 
## Which problem is this PR solving?
Bumps all OpenTelemetry dependencies across packages. However, due to
HTTP semantic convention changes coming in minor releases, we have not
upgraded to the latest packages available. Instead, we've upgrade the
instrumentation packages to the latest version
([1.6.0-beta.3](https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/1.6.0-beta.3))
that defaults to the old attribute names and offers an environment to
use the names or dual write old & new. The remaining packages were
updated to the latest version available when the affected instr package
were released (November 17 2023).

- Closes #364 

## Short description of the changes
- Bumps OTel instrumentation packacges to 1.6.0-beta.3
- Bumps remaining OTel dependnencies to latest version available when
those instr packages were published
- Add note to README to indicate why we've locked to a particular
version and link to our HTTP semantic convention docs guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: oncall Flagged for awareness from Honeycomb Telemetry Oncall type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

maint: Bump OpenTelemetry dependencies honeycombio/honeycomb-opentelemetry-dotnet
2 participants
@MikeGoldsmith @Al4ric