fix: metrics smoke tests #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkanal
added
type: bug
This was referenced Nov 15, 2022
MikeGoldsmith
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
When upgrading autoinstrumentation versions to rc9.9, the
OTEL_METRIC_EXPORT_INTERVALis supported and our smoke tests export interval is too short (100ms, we're checking for results every 1s) which causes smoke tests to fail. This PR removes the unused env variable.Short description of the changes
OTEL_METRIC_EXPORT_INTERVALoption set in the smoke tests docker-compose.yml--buildoption to smoke tests docker-compose step since without rebuilding it's hard to figure out if you're working with a previously cached build.