fix: Proposed fix for JSON ingestion issue #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentquirk
requested review from
MikeGoldsmith,
JamieDanielson,
pkanal and
robbkidd
MikeGoldsmith
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
I think this makes sense as OTLP/JSON spec shows traceID & spanID will only be hex and not base64 encoded.
The changes make functional sense but think the bytesToTraceID and bytesToSpanID funcs could be refactored to be a little cleaner. I also think we should rename the new consts for hex only encoded trace and span IDs -- they aren't corrupted, just not base64 encoded.
kentquirk
added a commit
that referenced
this pull request
Mar 8, 2023
## Which problem is this PR solving? - The bug fix in #179 had a bug, and it was found by a test in an internal library before deploy. ## Short description of the changes - Fix bug in BytesToTraceID - Add a test that would have found the bug, and more test cases for the new stuff This requires a release to v0.22.1.
kentquirk
added a commit
that referenced
this pull request
Jan 3, 2024
## Which problem is this PR solving? - In #179 we added some code to deal with the fact that OTLP/JSON processing can't differentiate between arrays of bytes that are encoded as hex and those that are encoded as base64. When JS sends us browser-side telemetry, it encodes IDs as hex, but when we receive it it's decoded as base64. This PR also applies that to logs. ## Short description of the changes - Adjust log's parentID so that it properly parses - Add a new test case - Move some code to common since it now applies across signals - Move some tests to common - Clarify some comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
OTLP/JSON data coming direct from browser sources is arriving with traceID and spanID encoded as hex, per spec.
But when this is fed through the OTLP protojson library that Husky uses, these values are being decoded as if they were encoded in base64.
The result is that Husky is corrupting these IDs.
Short description of the changes
BytesToTraceIDfunction and addsbytesToSpanIDto special-case the conversion (which we can detect by its length).