Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle KeyValue attributes with nil value #19

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Handle KeyValue attributes with nil value #19

merged 2 commits into from
Nov 29, 2021

Conversation

MikeGoldsmith
Copy link
Contributor

Which problem is this PR solving?

Handle scenario where a KeyValue's value field is nil.

Short description of the changes

  • Check the attribute value is not nil before trying to use it
  • Add unit test

@MikeGoldsmith MikeGoldsmith added the type: bug Something isn't working label Nov 29, 2021
@MikeGoldsmith MikeGoldsmith requested a review from a team November 29, 2021 13:14
@MikeGoldsmith MikeGoldsmith self-assigned this Nov 29, 2021
@MikeGoldsmith MikeGoldsmith added the version: bump minor A PR that adds behavior, but is backwards-compatible. label Nov 29, 2021
@MikeGoldsmith MikeGoldsmith added this to the v0.2.0 milestone Nov 29, 2021
@MikeGoldsmith MikeGoldsmith merged commit fcb95de into main Nov 29, 2021
@MikeGoldsmith MikeGoldsmith deleted the mike/nil-kv-value branch November 29, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbkidd robbkidd robbkidd left review comments

@JamieDanielson JamieDanielson JamieDanielson approved these changes

Assignees

@MikeGoldsmith MikeGoldsmith

Labels
type: bug Something isn't working version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MikeGoldsmith @robbkidd @JamieDanielson