-
Notifications
You must be signed in to change notification settings - Fork 40
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert the revert of "pre-define map capacities" (#201)
Reverts #200, which was a revert of a performance PR. I tried implementing the change that I was intending to make, and it just doesn't work well. A simple change runs the risk of blowing up memory in certain situations, so I had intended to make it configurable. But as a low-level library, libhoney-go has a well-trodden configuration path and doesn't really have a configuration model that allows for a transparent change. It would have needed to read the environment from within the libhoney Init() method and that's not really a good design. Otherwise we'd have to make all the callers of libhoney set it explicitly. My intent was a simpler solution, but this *is* the simpler solution, it turns out. Oh well.
- Loading branch information
Showing
1 changed file
with
24 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters