Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwrap, Masswrap & Massunwrap #3

Merged
merged 5 commits into from
Apr 7, 2023
Merged

Conversation

pkanal
Copy link

@pkanal pkanal commented Apr 6, 2023

Which problem is this PR solving?

Addresses unwrap, masswrap and massunwrap functionality as well as moving some things around to make things more Node friendly.

Short description of the changes

  • Added unwrap functionality + test
  • Added massWrap functionality + test
  • Added massUnwrap functionality + test
  • Moved the ESM specific wrap function logic to the node specific instrumentation.ts file so that we aren't doing Node specific things in methods that might be used in the browser.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Existing tests pass
  • Added new tests for new functionality
  • Tested with the ESM example app with http autoinstrumentation

@pkanal pkanal self-assigned this Apr 6, 2023
@pkanal pkanal changed the title Purvi.unwrap Unwrap, Masswrap & Massunwrap Apr 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

❗ No coverage uploaded for pull request base (esm-support@b722486). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 97e75c8 differs from pull request most recent head 86b6837. Consider uploading reports for the commit 86b6837 to get more accurate results

@@              Coverage Diff               @@
##             esm-support       #3   +/-   ##
==============================================
  Coverage               ?   93.67%           
==============================================
  Files                  ?      272           
  Lines                  ?     8287           
  Branches               ?     1717           
==============================================
  Hits                   ?     7763           
  Misses                 ?      524           
  Partials               ?        0           

@JamieDanielson JamieDanielson merged commit da694c7 into esm-support Apr 7, 2023
@MikeGoldsmith MikeGoldsmith deleted the purvi.unwrap branch April 11, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants