Skip to content

Commit

Permalink
Add a default sampler if none is specified (#193)
Browse files Browse the repository at this point in the history
Provide a default sampler to be used if none is specified
  • Loading branch information
martin308 authored Nov 13, 2020
1 parent 96843de commit 50772e3
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 0 deletions.
37 changes: 37 additions & 0 deletions config/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -401,3 +401,40 @@ func TestGetSamplerTypes(t *testing.T) {
assert.IsType(t, &EMADynamicSamplerConfig{}, d)
}
}

func TestDefaultSampler(t *testing.T) {
tmpDir, err := ioutil.TempDir("", "")
assert.NoError(t, err)
defer os.RemoveAll(tmpDir)

rulesFile, err := ioutil.TempFile(tmpDir, "*.toml")
assert.NoError(t, err)

configFile, err := ioutil.TempFile(tmpDir, "*.toml")
assert.NoError(t, err)

dummy := []byte(`
[InMemCollector]
CacheCapacity=1000
[HoneycombMetrics]
MetricsHoneycombAPI="http://honeycomb.io"
MetricsAPIKey="1234"
MetricsDataset="testDatasetName"
MetricsReportingInterval=3
`)

_, err = configFile.Write(dummy)
assert.NoError(t, err)
configFile.Close()

c, err := NewConfig(configFile.Name(), rulesFile.Name(), func(err error) {})

assert.NoError(t, err)

s, err := c.GetSamplerConfigForDataset("nonexistent")

assert.NoError(t, err)

assert.IsType(t, &DeterministicSamplerConfig{}, s)
}
4 changes: 4 additions & 0 deletions config/file_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,10 @@ func NewConfig(config, rules string, errorCallback func(error)) (Config, error)
}

r := viper.New()

r.SetDefault("Sampler", "DeterministicSampler")
r.SetDefault("SampleRate", 1)

r.SetConfigFile(rules)
err = r.ReadInConfig()

Expand Down

0 comments on commit 50772e3

Please sign in to comment.