Skip to content

Commit

Permalink
fix: Remove excess validation for api keys (#786)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?

- API key validation was not allowing envvars to be properly validated,
so we're removing it.

## Short description of the changes

- Rip it out.
  • Loading branch information
kentquirk authored Jul 11, 2023
1 parent 9c6560c commit a26d394
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions config/metadata/configMeta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,6 @@ groups:
envvar: REFINERY_HONEYCOMB_LOGGER_API_KEY, REFINERY_HONEYCOMB_API_KEY
commandline: logger-api-key
validations:
- type: requiredInGroup
- type: format
arg: apikey
summary: is the API key used to send Refinery's logs to Honeycomb.
Expand Down Expand Up @@ -544,7 +543,6 @@ groups:
example: "SetThisToAHoneycombKey"
reload: false
validations:
- type: requiredInGroup
- type: format
arg: apikey
envvar: REFINERY_HONEYCOMB_METRICS_API_KEY, HONEYCOMB_API_KEY
Expand Down Expand Up @@ -614,6 +612,9 @@ groups:
default: ""
example: "SetThisToAHoneycombKey"
reload: false
validations:
- type: format
arg: apikey
envvar: REFINERY_METRICS_OTEL_API_KEY, HONEYCOMB_API_KEY
commandline: otel-metrics-api-key
firstversion: v2.0
Expand Down

0 comments on commit a26d394

Please sign in to comment.