Skip to content

Commit

Permalink
Now make sure things work and tests pass again
Browse files Browse the repository at this point in the history
Signed-off-by: Davin Taddeo <davin@honeycomb.io>
  • Loading branch information
tdarwin committed Mar 8, 2023
1 parent 83d9fc3 commit a59f38c
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions collect/collect.go
Original file line number Diff line number Diff line change
Expand Up @@ -624,13 +624,11 @@ func mergeTraceAndSpanSampleRates(sp *types.Span, traceSampleRate uint, dryRunMo
func (i *InMemCollector) isRootSpan(sp *types.Span) bool {
for _, parentIdFieldName := range i.Config.GetParentIdFieldNames() {
parentId := sp.Data[parentIdFieldName]
if parentId == nil {
continue
} else {
return true
if _, ok := parentId.(string); ok {
return false
}
}
return false
return true
}

func (i *InMemCollector) send(trace *types.Trace, reason string) {
Expand Down

0 comments on commit a59f38c

Please sign in to comment.