Fix crash bug related to sharding

honeycombio · May 16, 2022 · d1a8cfa · d1a8cfa
1 parent 744df42
commit d1a8cfa
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/sharder/deterministic.go b/sharder/deterministic.go
@@ -227,6 +227,12 @@ func (d *DeterministicSharder) WhichShard(traceID string) Shard {
 	portion := math.MaxUint32 / len(d.peers)
 	index := v / uint32(portion)
 
+	// #454 -- index can get out of range if v is close to 0xFFFFFFFF and portion would be non-integral.
+	// Consider revisiting this with a different sharding mechanism if we rework our scaling behavior.
+	if index > uint32(len(d.peers)) {
+		index = 0
+	}
+
 	return d.peers[index]
 }