Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a lot more diagnostics during startup before Refinery is running. #1277

Closed
kentquirk opened this issue Aug 15, 2024 · 0 comments · Fixed by #1308
Closed

Add a lot more diagnostics during startup before Refinery is running. #1277

kentquirk opened this issue Aug 15, 2024 · 0 comments · Fixed by #1308
Assignees
@kentquirk
Labels
type: enhancement New feature or request
Milestone
v2.8

Comments

@kentquirk
Copy link
Contributor

Is your feature request related to a problem? Please describe.

If Refinery is waking up and can't reach Redis or its peers, it doesn't log much at all (or at least not anything useful).

Describe the solution you'd like

We should be a lot more proactive during startup about logging accurate guesses for the reasons for issues encountered, and not simply pass errors up the stack that get logged at the top level and often have very little to do with the actual problem.

We can probably also improve some documentation around configuration if you're not using Kubernetes.
@kentquirk kentquirk added the type: enhancement New feature or request label Aug 15, 2024
@kentquirk kentquirk added this to the v2.8 milestone Aug 16, 2024
@kentquirk kentquirk self-assigned this Aug 29, 2024
@kentquirk kentquirk mentioned this issue Sep 3, 2024
Merged
kentquirk added a commit that referenced this issue Sep 4, 2024
@kentquirk
maint: Add some extra logging to pubsub systems (#1308)
34734d2 
## Which problem is this PR solving?

- Add a bit more logging to redis stuff to make it easier to diagnose
- Closes #1277 

## Short description of the changes

- Add some logging in pubsub
- Delete an unused function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kentquirk kentquirk

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
v2.8
Development

Successfully merging a pull request may close this issue.

maint: Add some extra logging to pubsub systems honeycombio/refinery
1 participant
@kentquirk