Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a config option for disabling the new trace distribution strategy #1326

Closed
VinozzZ opened this issue Sep 12, 2024 · 1 comment
Closed

Add a config option for disabling the new trace distribution strategy #1326

VinozzZ opened this issue Sep 12, 2024 · 1 comment
Assignees
@VinozzZ
Labels
status: blocked type: enhancement New feature or request
Milestone
v2.9

Comments

@VinozzZ
Copy link
Contributor

VinozzZ commented Sep 12, 2024

We need to allow users to keep trace locality if the new trace distribution feature does not work for certain use cases
@VinozzZ VinozzZ added this to the v2.9 milestone Sep 12, 2024
@MikeGoldsmith MikeGoldsmith self-assigned this Sep 16, 2024
@MikeGoldsmith MikeGoldsmith added the type: enhancement New feature or request label Sep 16, 2024
@MikeGoldsmith
Copy link
Contributor

Not ready yet, need to wait for the following to be complete first:

@MikeGoldsmith MikeGoldsmith removed their assignment Sep 16, 2024
@VinozzZ VinozzZ mentioned this issue Sep 18, 2024
Merged
VinozzZ added a commit that referenced this issue Oct 2, 2024
@VinozzZ
feat: forward decision span through peer endpoint (#1342)
0eac5f0 
## Which problem is this PR solving?

implements: #1318 #1326 

## Short description of the changes

- Add a new config option `ForceTraceLocality` to turn off trace
distribution feature
- forward decision spans when peer membership changes
TylerHelmuth pushed a commit that referenced this issue Oct 16, 2024
@VinozzZ @TylerHelmuth
feat: forward decision span through peer endpoint (#1342)
f4d3f9f 
implements: #1318 #1326

- Add a new config option `ForceTraceLocality` to turn off trace
distribution feature
- forward decision spans when peer membership changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VinozzZ VinozzZ

Labels
status: blocked type: enhancement New feature or request
Projects
None yet
Milestone
v2.9
Development

No branches or pull requests
3 participants
@MikeGoldsmith @akvanhar @VinozzZ