Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samproxy ignores proxy settings in the environment #44

Closed
maplebed opened this issue Jul 1, 2019 · 0 comments · Fixed by #45
Closed

samproxy ignores proxy settings in the environment #44

maplebed opened this issue Jul 1, 2019 · 0 comments · Fixed by #45

Comments

@maplebed
Copy link
Contributor

maplebed commented Jul 1, 2019

If the environment variable HTTPS_PROXY is set, samproxy should use that proxy to send traffic. In the current state, traffic is sent directly to Honeycomb regardless of the setting of the environment.
@maplebed maplebed mentioned this issue Jul 1, 2019
Merged
maplebed added a commit that referenced this issue Jul 1, 2019
@maplebed
honor proxy settings in the environment (#45)
19a244b 
Resolves #44

The default go http library honors settings from the environment with the built in ProxyFromEnvironment function. This change configures samproxy to use the same thing.

Coming along for the ride is an update to the circle ci config to get the build to run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

honor proxy settings in the environment honeycombio/refinery
1 participant
@maplebed