Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect Libhoney metrics when using prometheus #446

Closed
drew-eero opened this issue May 5, 2022 · 3 comments · Fixed by #692
Closed

Collect Libhoney metrics when using prometheus #446

drew-eero opened this issue May 5, 2022 · 3 comments · Fixed by #692
Labels
status: help wanted Seeking more eyes and hands. type: enhancement New feature or request

Comments

@drew-eero
Copy link

Hi All,

Info:

I'm not seeing any of the libhoney metrics described in the scaling documentation here https://docs.honeycomb.io/manage-data-volume/refinery/scale-and-troubleshoot/#sizing-the-send-buffers in prometheus. Any idea why I'm getting all the other metrics but not libhoney?

@drew-eero drew-eero added the type: discussion Requests for comments, discussions about possible enhancements. label May 5, 2022
@MikeGoldsmith MikeGoldsmith self-assigned this May 6, 2022
@MikeGoldsmith MikeGoldsmith added the status: oncall Flagged for awareness from Honeycomb Telemetry Oncall label May 6, 2022
@MikeGoldsmith
Copy link
Contributor

Hi @drew-eero - thanks for creating the issue.

It doesn't look like the prometheus metrics in refinery subscribe to libhoney's metrics, it only subscribes to the refinery metrics. I think it is an oversight, and agree they would be useful to add if possible.

I've updated the ticket title to reflect tracking adding libhoney metrics to the prometheus managed metrics. I'm unsure when we'll get a chance to schedule this work, but we're always welcoming of community contributions.

Thanks 👍🏻

@MikeGoldsmith MikeGoldsmith changed the title Libhoney metrics are not showing up in prometheus. Collect Libhoney metrics when using prometheus May 9, 2022
@MikeGoldsmith MikeGoldsmith added type: enhancement New feature or request status: help wanted Seeking more eyes and hands. and removed type: discussion Requests for comments, discussions about possible enhancements. status: oncall Flagged for awareness from Honeycomb Telemetry Oncall labels May 9, 2022
@kentquirk
Copy link
Contributor

For reference, this is related to #351.

@masonjlegere
Copy link

We would also like to use Prometheus for some of libhoney metrics. I'll try and make a contribution to add them over the next few days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help wanted Seeking more eyes and hands. type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants