Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [v2] Metrics cleanup #692

Merged
merged 15 commits into from
Jun 2, 2023
Merged

feat: [v2] Metrics cleanup #692

merged 15 commits into from
Jun 2, 2023

Conversation

kentquirk
Copy link
Contributor

@kentquirk kentquirk commented May 26, 2023

Which problem is this PR solving?

V2 metrics cleanup. V2 config rework gave us the ability to send metrics to multiple places. This adds that, plus a new OTel metrics target.

Short description of the changes

  • HoneycombMetrics renamed to LegacyMetrics
  • Multi-metrics object added so we can have metrics go to multiple destinations
  • Fix a bug where stress relief wouldn't work if you don't have any metrics -- now it will
  • Add OTel metrics destination
  • Fetching config values can't error, so start removing some of the always-nil error returns to simplify things
  • MultiMetrics tracks data for StressRelief (Store and Get)
  • Injection system taught how to build a MultiMetrics object properly

Closes #562
Closes #581
Closes #446
Closes #351

It doesn't quite deal with #624 or #691 yet because the metrics being sent haven't been changed. Those will be a separate PR.

@kentquirk kentquirk changed the base branch from main to kent.use_new_config May 26, 2023 01:36
@kentquirk kentquirk force-pushed the kent.multi_metrics branch from 2dbb12a to b3163b8 Compare May 26, 2023 02:09
Base automatically changed from kent.use_new_config to main May 26, 2023 16:19
@kentquirk kentquirk marked this pull request as ready for review May 31, 2023 01:45
@kentquirk kentquirk requested a review from a team as a code owner May 31, 2023 01:45
@kentquirk kentquirk added this to the v2.0 milestone May 31, 2023
metrics/multi_metrics.go Outdated Show resolved Hide resolved
metrics/otel_metrics.go Outdated Show resolved Hide resolved
metrics/otel_metrics.go Show resolved Hide resolved
metrics/otel_metrics.go Outdated Show resolved Hide resolved
config/file_config.go Show resolved Hide resolved
metrics/storemetrics.go Outdated Show resolved Hide resolved
@kentquirk kentquirk requested a review from TylerHelmuth June 2, 2023 13:16
@kentquirk kentquirk merged commit 8b9cac3 into main Jun 2, 2023
@kentquirk kentquirk deleted the kent.multi_metrics branch June 2, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants