Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample rate not being set correctly for spans that show up late #468

Closed
kentquirk opened this issue Jun 17, 2022 · 0 comments · Fixed by #504
Closed

Sample rate not being set correctly for spans that show up late #468

kentquirk opened this issue Jun 17, 2022 · 0 comments · Fixed by #504
Labels
type: bug Something isn't working

Comments

@kentquirk
Copy link
Contributor

It looks like dealWithSentTrace is not setting 0 sample rates to 1 before doing its multiplication. The result is that some spans show up at Honeycomb without having SampleRate set (because the sample rate is the zero value so therefore not set).

Additional context

There is an internal slack thread at Honeycomb where this problem was discovered.
@kentquirk kentquirk added the type: bug Something isn't working label Jun 17, 2022
@kentquirk kentquirk mentioned this issue Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sample rate for late spans honeycombio/refinery
1 participant
@kentquirk