Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sample rate for late spans #504

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Fix sample rate for late spans #504

merged 1 commit into from
Sep 7, 2022

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • If sample rate < 1 on a late span, set it to 1 before doing any further sample rate math.

@kentquirk kentquirk requested review from a team and robbkidd September 6, 2022 22:02
MikeGoldsmith
MikeGoldsmith approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-59491240

@MikeGoldsmith MikeGoldsmith added type: bug Something isn't working version: bump patch A PR with release-worthy changes and is backwards-compatible. labels Sep 7, 2022
@kentquirk kentquirk merged commit deff8e4 into main Sep 7, 2022
@kentquirk kentquirk deleted the kent.468 branch September 7, 2022 12:47
ghost pushed a commit to opsramp/tracing-proxy that referenced this pull request Jul 5, 2024
@kentquirk
Fix sample rate for late spans (honeycombio#504)
3a7618a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

@robbkidd robbkidd Awaiting requested review from robbkidd

Assignees

@kentquirk kentquirk

Labels
type: bug Something isn't working version: bump patch A PR with release-worthy changes and is backwards-compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sample rate not being set correctly for spans that show up late
2 participants
@kentquirk @MikeGoldsmith