You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reload code in v2 has a deadlock -- inside monitor(), there's a lock around the reload, but the lock also encloses the callbacks. This requires access to config values that are now write-locked. This wasn't detected in testing because we didn't set up callbacks in testing.
## Which problem is this PR solving?
- Live reload deadlock seen in #807
## Short description of the changes
- Move unlock above the callbacks, fix comment
Fixes#807
The reload code in v2 has a deadlock -- inside monitor(), there's a lock around the reload, but the lock also encloses the callbacks. This requires access to config values that are now write-locked. This wasn't detected in testing because we didn't set up callbacks in testing.
The Unlock() needs to move up above the callbacks.
The text was updated successfully, but these errors were encountered: