Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new metric for drops caused by rules #1047

Merged
merged 3 commits into from
Mar 11, 2024
Merged

feat: new metric for drops caused by rules #1047

merged 3 commits into from
Mar 11, 2024

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Adds a new metric, num_dropped_by_drop_rule, which tracks this value.

Fixes #974

@kentquirk kentquirk requested a review from a team as a code owner March 9, 2024 16:54
@kentquirk kentquirk added this to the v2.5 milestone Mar 10, 2024
VinozzZ
VinozzZ reviewed Mar 11, 2024
View reviewed changes
sample/rules.go Outdated Show resolved Hide resolved
VinozzZ
VinozzZ approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@VinozzZ VinozzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kentquirk kentquirk merged commit 3bf4232 into main Mar 11, 2024
3 checks passed
@kentquirk kentquirk deleted the kent.974 branch March 11, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinozzZ VinozzZ VinozzZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.5
Development

Successfully merging this pull request may close these issues.

Create a metric for traces/spans dropped by drop rules specifically
2 participants
@kentquirk @VinozzZ