Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add some useful generics #1206

Merged
merged 8 commits into from
Jun 18, 2024
Merged

feat: Add some useful generics #1206

merged 8 commits into from
Jun 18, 2024

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

  • Some features I plan to import from Refinery 3 will likely use the Fanout generic that was added there
  • The gossip-based peer mechanism will need SetWithTTL

Short description of the changes

  • Create and test SetWithTTL
  • Import code and tests for Fanout

@kentquirk kentquirk requested a review from a team as a code owner June 16, 2024 21:30
VinozzZ
VinozzZ reviewed Jun 17, 2024
View reviewed changes
generics/fanout_test.go Outdated Show resolved Hide resolved
generics/fanout_test.go Outdated Show resolved Hide resolved
generics/setttl.go Outdated Show resolved Hide resolved
generics/setttl.go Show resolved Hide resolved
generics/setttl.go Outdated Show resolved Hide resolved
@kentquirk kentquirk merged commit 07202af into main Jun 18, 2024
3 checks passed
@kentquirk kentquirk deleted the kent.generics branch June 18, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinozzZ VinozzZ VinozzZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kentquirk @VinozzZ