fix: Don’t consider log events as root spans #1208
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Log events should never be considered root spans even though they do not contain a
trace.parent_id
. A log event that is part of a trace would mark the trace complete as if it's considered a root span.This change updates the check for whether a span is considered a root span to also check for the meta field
meta.signal_type
. If the field exists and is set to "log", we return false.Short description of the changes
InMemoryCollector.isRootSpan
to check ifmeta.signal_type
and has a value of "log"