Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: track config hash on config reload #1212

Merged
merged 3 commits into from
Jun 20, 2024
Merged

feat: track config hash on config reload #1212

merged 3 commits into from
Jun 20, 2024

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Jun 18, 2024 •
edited by kentquirk
Loading

Which problem is this PR solving?

To provide better visibility of current configuration used in Refinery, this PR introduce two metrics, config_hash and rule_config_hash, for keeping track of configuration.

Short description of the changes

  • change config change log from info level to warn
  • include full config hash value in config change log
  • store the decimal number of the last 4 digit of config hash value as metrics

#967

@VinozzZ VinozzZ requested a review from a team as a code owner June 18, 2024 22:06
@VinozzZ VinozzZ added this to the v2.7 milestone Jun 18, 2024
kentquirk
kentquirk reviewed Jun 18, 2024
View reviewed changes
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is overkill; how do you feel about simplifying it?

config/configLoadHelpers_test.go Show resolved Hide resolved
config/configLoadHelpers.go Outdated Show resolved Hide resolved
@VinozzZ VinozzZ requested a review from kentquirk June 20, 2024 14:37
kentquirk
kentquirk approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@VinozzZ VinozzZ merged commit 4a7077d into main Jun 20, 2024
3 checks passed
@VinozzZ VinozzZ deleted the yingrong.config_hash_metric branch June 20, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentquirk kentquirk kentquirk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.7
Development

Successfully merging this pull request may close these issues.
2 participants
@VinozzZ @kentquirk