feat: add otel tracing support for Refinery internal operations #1218
Conversation
There was a problem hiding this comment.
This looks great to enable tracing. Now, of course, we have to start using it, but at least this way it's available.
We should start using it in some places before we release a system that has it in the config, or people will think it's broken. That can be a separate PR, though.
|
|
||
| var sampleRatio float64 = 1.0 / float64(sampleRate) | ||
|
|
||
| headers := map[string]string{ |
There was a problem hiding this comment.
I know this is straight from R3, but I just noticed this is unconditionally adding the API Key headers, which is not what we say in the docs. We should be adding this APIKeyHeader only if APIKey is non-blank. That way we don't put the header if a user is sending the traces to some other OTel endpoint.
There was a problem hiding this comment.
There's a check for APIKey on line 80 to only set up a tracer if APIKey is not empty
Co-authored-by: Kent Quirk <kentquirk@honeycomb.io>
Co-authored-by: Kent Quirk <kentquirk@honeycomb.io>
Which problem is this PR solving?
Enable otel tracing for debugging Refinery internal operations.
Short description of the changes
github.com/honeycombio/opentelemetry-proto-go/otlpto v1.3.1#1213