-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: peer management on pubsub via callbacks #1220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm more inclined to remove the existing redis peer management logic. Couple reasons that comes to mind:
- since the pub/sub implementation is still using redis, having it as a separate config option feels a bit confusing for me
- does that mean
stress_relief
also needs atype
option so that customers can choose to stay with the existing stress relief mechanism? - I can't think of a scenario that customers will want to stay with the existing redis implementation if pub/sub system ultimately enables scaling without loosing data.
- it would be nice that we can just have one redis package in refinery instead of maintaining two implementation
}) | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about a test with multiple peers that can get correct number of peers and the callback functions are called when a peer joins or leaves the cluster?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been trying to write that test, and it's not real easy to run multiple peers on the same machine. I think it's possible, but it might need some gymnastics to make it happen.
Because I'm going on vacation now, I'm going to merge this so it doesn't get stale while I'm gone. We can look at that test another time.
…nto kent.pubsub_on_cb
Which problem is this PR solving?
Short description of the changes
closes #1201