Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure to inject Health object as a pointer #1237

Merged
merged 2 commits into from
Jul 18, 2024
Merged

fix: make sure to inject Health object as a pointer #1237

merged 2 commits into from
Jul 18, 2024

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Jul 18, 2024

Which problem is this PR solving?

Refinery panics on start

Short description of the changes

  • inject Health as a pointer

@VinozzZ VinozzZ requested a review from a team as a code owner July 18, 2024 19:54
kentquirk
kentquirk approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swear I ran this. Apparently not. Thanks.

@VinozzZ VinozzZ merged commit e3e9a9f into main Jul 18, 2024
5 checks passed
@VinozzZ VinozzZ deleted the yingrong.fix_health_injection branch July 18, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentquirk kentquirk kentquirk approved these changes

Assignees

@VinozzZ VinozzZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VinozzZ @kentquirk