Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove otel-config-go as a dependency #1240

Merged
merged 3 commits into from
Jul 22, 2024
Merged

fix: remove otel-config-go as a dependency #1240

merged 3 commits into from
Jul 22, 2024

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Jul 19, 2024

Which problem is this PR solving?

The maintenance effort required to keep semantic convention in sync between otel-config-go and otel has led us to remove otel-config-go as a dependency

Short description of the changes

  • configure otel using vanilla otel sdk

@VinozzZ VinozzZ requested a review from a team as a code owner July 19, 2024 20:04
@VinozzZ VinozzZ self-assigned this Jul 19, 2024
@VinozzZ VinozzZ added the type: enhancement New feature or request label Jul 19, 2024
kentquirk
kentquirk approved these changes Jul 20, 2024
View reviewed changes
Copy link
Contributor

@kentquirk kentquirk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please do a go mod tidy before merging.

@VinozzZ VinozzZ merged commit 023fe0f into main Jul 22, 2024
5 checks passed
@VinozzZ VinozzZ deleted the yingrong.configure_otel branch July 22, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentquirk kentquirk kentquirk approved these changes

Assignees

@VinozzZ VinozzZ

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VinozzZ @kentquirk