-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maint: Update licenses #1244
maint: Update licenses #1244
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a question but nothing blocking
@@ -68,16 +68,16 @@ clean: | |||
|
|||
.PHONY: install-tools | |||
install-tools: | |||
go install github.com/google/go-licenses@v1.0.0 | |||
go install github.com/google/go-licenses/v2@v2.0.0-alpha.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to use an alpha version here? Also wondering if we should separate this into an env var further up so it's easier to spot and change (similar to the dockerize versions), vs in the middle of the command. No strong opinion here though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tool has been slow to evolve with many changes in the 1.x versions; we were stuck on 1.0 because of problems with later versions. I'd personally rather see us standardize on 2.x even if it's alpha.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there would be a need to dynamically update the liceses version and as Kent said, they release versions very slowly. Let's go with this as is for now, and add the env var later if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This got rid of the main LICENSE file for the repo @TylerHelmuth @codeboten. Was that intended?
Which problem is this PR solving?
Closes #1242
Short description of the changes
update-licenses
verify-licenses
to run the logic again