Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: FilePeers implies no Redis #1251

Merged
merged 2 commits into from
Jul 26, 2024
Merged

fix: FilePeers implies no Redis #1251

merged 2 commits into from
Jul 26, 2024

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

  • If someone specified FilePeers, then we are assuming they don't want to run Redis.

Short description of the changes

  • Simplify logic; if FilePeers, no redis and only local pubsub.
  • Update some of the documentation.

@kentquirk kentquirk requested a review from a team as a code owner July 25, 2024 21:59
@kentquirk kentquirk self-assigned this Jul 25, 2024
@kentquirk kentquirk added this to the v2.7 milestone Jul 25, 2024
@kentquirk kentquirk merged commit 31d2ce2 into main Jul 26, 2024
5 checks passed
@kentquirk kentquirk deleted the kent.file_means_no_redis branch July 26, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinozzZ VinozzZ VinozzZ approved these changes

Assignees

@kentquirk kentquirk

Labels
None yet
Projects
None yet
Milestone
v2.7
Development

Successfully merging this pull request may close these issues.
2 participants
@kentquirk @VinozzZ