Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow more complex key behavior #1263

Merged
merged 6 commits into from
Aug 7, 2024
Merged

feat: Allow more complex key behavior #1263

merged 6 commits into from
Aug 7, 2024

Conversation

kentquirk
Copy link
Contributor

@kentquirk kentquirk commented Aug 1, 2024 •
edited
Loading

Which problem is this PR solving?

Short description of the changes

  • Add SendKeys and SendKeysMode to config
  • Implement a new route handler for http
  • Document it in the metadata
  • Document it in the readme
  • Implement it for OTLP traces
  • Implement it for OTLP logs

Closes #634.

@kentquirk kentquirk marked this pull request as ready for review August 7, 2024 16:32
@kentquirk kentquirk requested a review from a team as a code owner August 7, 2024 16:32
@kentquirk kentquirk self-assigned this Aug 7, 2024
@kentquirk kentquirk added this to the v2.8 milestone Aug 7, 2024
VinozzZ
VinozzZ approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@VinozzZ VinozzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. I think we should add some tests for the CheckAndMaybeReplaceKey function

@kentquirk
Copy link
Contributor Author

It was a good idea to write some more tests. I found a couple of bugs that way. Thanks for the nudge.

@kentquirk kentquirk merged commit ef21c5e into main Aug 7, 2024
5 checks passed
@kentquirk kentquirk deleted the kent.sendkey branch August 7, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinozzZ VinozzZ VinozzZ approved these changes

Assignees

@kentquirk kentquirk

Labels
None yet
Projects
None yet
Milestone
v2.8
Development

Successfully merging this pull request may close these issues.

Allow setting API Key on Refinery
2 participants
@kentquirk @VinozzZ