feat: Add SpanLimit (includes some config changes) #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinozzZ
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Looks good to me! Would nice to also have a unit test in collect_test.go to confirm a trace is sent when its span count surpass the configured SpanLimit.
I'm also wondering if the SpanLimit can be used in CacheImpact calculation so that we can eject giant traces first when there's memory pressure
|
I added that test. We already use a cache impact calculation, which is a combination of memory usage and duration in the cache to eject the largest traces first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
#1257 -- helps to keep Refinery from exploding when a giant trace arrives.
Short description of the changes