fix: don't read more than max bytes from a request #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinozzZ
approved these changes
Aug 15, 2024
kentquirk
added a commit
that referenced
this pull request
Aug 15, 2024
## Which problem is this PR solving? - If the compressed input to an HTTP request is too big, it can cause Refinery to have difficulties. ## Short description of the changes - Set a request max for the HTTP inputs /1/batch and /1/events - Remove bogus syntax from test config I don't have a good way to test this in CI, but it was extensively tested locally.
kentquirk
added a commit
that referenced
this pull request
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
I don't have a good way to test this in CI, but it was extensively tested locally.