Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: Delete unused Dockerfile #1292

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

TylerHelmuth
Copy link
Contributor

Which problem is this PR solving?

  • the repo contains a dockerfile that is not used in any of our CI or make commands. It has been the source of confusion around our released image's source. This Dockerfile was only intended to be used in local docker build . commands, but has not outlived its usefulness.

Short description of the changes

  • Deletes the Dockerfile.

If alternatively, we want to keep the dockerfile, I could clean it up to bring it in line with best security practices AND try to make it clearer that it isn't used to build our images.

@TylerHelmuth TylerHelmuth requested a review from a team as a code owner August 20, 2024 21:45
Copy link
Member

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this removal. The shipped release image is built with ko. When using an image locally, we should be using the same build process.

Thank you. NEXT!

@robbkidd robbkidd added version: no bump A PR with maintenance or doc changes that aren't included in a release. type: maintenance The necessary chores to keep the dust off. labels Aug 20, 2024
@TylerHelmuth TylerHelmuth merged commit a3e9090 into main Aug 22, 2024
5 checks passed
@TylerHelmuth TylerHelmuth deleted the tyler.remove-unused-dockerfile branch August 22, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants