Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support layered (multiple) configuration files #1301

Merged
merged 8 commits into from
Aug 29, 2024
Merged

feat: support layered (multiple) configuration files #1301

merged 8 commits into from
Aug 29, 2024

Conversation

kentquirk
Copy link
Contributor

@kentquirk kentquirk commented Aug 27, 2024 •
edited
Loading

Which problem is this PR solving?

  • Support the ability to specify multiple configuration files; this is in support of a future feature to allow remote editing of some of a configuration, while leaving other parts untouched.
  • Closes Can we support layered configs? #871

Short description of the changes

  • Make config/env values into slices
  • Make it possible to read/combine configurations
  • Add a little documentation

@kentquirk kentquirk requested a review from a team as a code owner August 27, 2024 01:31
@kentquirk kentquirk self-assigned this Aug 27, 2024
@kentquirk kentquirk added this to the v2.8 milestone Aug 27, 2024
VinozzZ
VinozzZ reviewed Aug 29, 2024
View reviewed changes
config/cmdenv.go Outdated Show resolved Hide resolved
@kentquirk kentquirk requested a review from VinozzZ August 29, 2024 14:29
@kentquirk kentquirk requested a review from VinozzZ August 29, 2024 14:43
VinozzZ
VinozzZ approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@VinozzZ VinozzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally. It works like a charm 🥇

config/configLoadHelpers_test.go Outdated Show resolved Hide resolved
@kentquirk kentquirk merged commit 8317a10 into main Aug 29, 2024
5 checks passed
@kentquirk kentquirk deleted the kent.layered_config branch August 29, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinozzZ VinozzZ VinozzZ approved these changes

Assignees

@kentquirk kentquirk

Labels
None yet
Projects
None yet
Milestone
v2.8
Development

Successfully merging this pull request may close these issues.

Can we support layered configs?
2 participants
@kentquirk @VinozzZ