Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add IN operator #1302

Merged
merged 5 commits into from
Aug 30, 2024
Merged

feat: add IN operator #1302

merged 5 commits into from
Aug 30, 2024

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

  • Fixes IN operator #1074
  • Adds In and NotIn operators to Refinery rules, and allows the Value field to become a list of values.

Short description of the changes

  • Change validation so that we can specify multiple Values
  • Implement In and NotIn operators
  • Write tests
  • Document

@kentquirk kentquirk requested a review from a team as a code owner August 29, 2024 18:46
VinozzZ
VinozzZ reviewed Aug 29, 2024
View reviewed changes
config/sampler_config_test.go Outdated Show resolved Hide resolved
config/validate.go Show resolved Hide resolved
@kentquirk kentquirk requested a review from VinozzZ August 30, 2024 00:46
@kentquirk kentquirk merged commit 0c38e22 into main Aug 30, 2024
5 checks passed
@kentquirk kentquirk deleted the kent.in_op branch August 30, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinozzZ VinozzZ VinozzZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IN operator
2 participants
@kentquirk @VinozzZ